Add config option to pass raw h11 headers #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pgjones have you had a chance to mull it over? |
|
ping @pgjones, sorry for being annoying. this would be really useful for us! |
|
I'm ok with this, it does seem to come up a lot. Fixed in 3179d07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue of header casing for HTTP/1.1 in hypercorn was addressed with #66, but later reverted with #77. The relevant ASGI spec is being discussed here django/asgiref#246.
This PR adds a config option to accommodate both ways of treating headers, where the default retains the current behavior which is lowercasing all headers.
This would help unblock localstack/localstack#6849 without us having to fork hypercorn or switch to a different server.
@pgjones please let me know if this would be an acceptable compromise, I know adding config options for edge cases is not great.